chore: Bump Buf to v1.32.0 and move to v2 #41735
Conversation
api/proto/buf.lock
Outdated
| @@ -4,8 +4,10 @@ deps: | |||
| - remote: buf.build | |||
| owner: gogo | |||
| repository: protobuf | |||
| commit: b03c65ea87cdc3521ede29f62fe3ce239267c1bc | |||
There was a problem hiding this comment.
Buf v1.32.0 is really unhappy about this hash. I ended up deleting the lock files and creating them again with buf dep update.
AFAICT this is still the same underlying commit, except the hash is from the Buf registry: https://buf.build/gogo/protobuf/commits/commit/4df00b267f944190a229ce3695781e99. If you look under "associated labels" you can see b03c65ea87cdc3521ede29f62fe3ce239267c1bc in there.
| * member (each proto3 optional field gets its own synthetic oneof). Synthetic | ||
| * oneofs exist in the descriptor only, and do not generate any API. Synthetic | ||
| * oneofs must be ordered after all "real" oneofs. | ||
| * When proto3_optional is true, this field must belong to a oneof to signal |
There was a problem hiding this comment.
Unclear to me why this changed now, but it seems to be mostly edition related.
| @@ -1,7 +1,4 @@ | |||
| version: v1 | |||
| deps: | |||
There was a problem hiding this comment.
This dep is not in use so I just took it out.
|
I do have a draft for a v2 config, but it's giving me trouble over a |
I got it. I'll mail something Monday. |
|
PTAL - migrated to v2 config. It actually cuts some duplication in the linter declarations. |
|
Buf breaking is mad because it wants 32-char lock commits on the master branch too. It looks like we can push that even with Buf v1.31, so I've done that at #41776. |
53a66af to
b9fd02c
Compare
|
@codingllama See the table below for backport results.
|
This reverts commit c585850.
Update to the latest release and migrate configs to v2.