Add --bind-addr, fixes #2620 #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Apr 10, 2019
webvictim
reviewed
Apr 10, 2019
This commit adds `--bind-addr` flag to tsh login and TELEPORT_LOGIN_BIND_ADDR environment variable to set up login bind address for SSO redirect flows. Usage examples: ``` tsh login --bind-addr=localhost:3333 tsh login --bind-addr=:3333 tsh login --bind-addr=[::1]:3333 TELEPORT_LOGIN_BIND_ADDR=localhost:7777 tsh login ```
russjones
approved these changes
Apr 10, 2019
|
Not to be ungrateful, but this only fixes half of #2620. When run inside a Docker container, it still does not produce a URL that is accessible from the host. It still uses a random port on the container's localhost. Maybe you could use a URL on the Teleport proxy web server instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
--bind-addrflag to tsh loginand TELEPORT_LOGIN_BIND_ADDR environment variable
to set up login bind address for SSO redirect flows.
Usage examples: