Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] Revert usage of session.SetEnvs #24801

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Apr 19, 2023

Due to unknown session requests causing sessions to be terminated in prior versions we cannot use session.SetEnvs without breaking backward compatibility until v14.

#23874 only exists in the latest versions of v12, so anyone upgrading to v13 from an older version of v12 will be unable to establish a SSH session.

Due to unknown session requests causing sessions to be terminated
in prior version we cannot use `session.SetEnvs` without breaking
backward compatability until v14.
@rosstimothy rosstimothy requested a review from gzdunek April 19, 2023 12:36
@rosstimothy rosstimothy marked this pull request as ready for review April 19, 2023 12:36
@github-actions github-actions bot requested review from avatus and r0mant April 19, 2023 12:37
@rosstimothy rosstimothy enabled auto-merge April 19, 2023 12:38
@rosstimothy rosstimothy added this pull request to the merge queue Apr 19, 2023
Merged via the queue into branch/v13 with commit ecf77ec Apr 19, 2023
@rosstimothy rosstimothy deleted the tross/revert_envs branch April 19, 2023 13:23
@r0mant r0mant mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants