Fix tctl test timeouts #24101
Merged
Fix tctl test timeouts #24101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Apr 6, 2023
smallinsky
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24100 and fixes #24005.
After a bunch of attempts and log investigations, I came to conclusion that there may be some race between auth and proxy startup and shutdown if it happens very quickly (as it does in tests).
I used flaky tests detector to troubleshoot my "guinea pig" test (
TestAppResource) and it failed every single time (see the history of my attempts below lol). After adding the wait for the proxy init event the flakiness check hasn't failed once on it (after 5-6 retries).