Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12] Close auth clients in tctl tests #24014

Merged
merged 1 commit into from
Apr 4, 2023
Merged

[v12] Close auth clients in tctl tests #24014

merged 1 commit into from
Apr 4, 2023

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Apr 3, 2023

Backport #24011 to branch/v12

@zmb3
Close auth clients in tctl tests
6fa9f06 
Goroutine dumps from failed tests show a large number of goroutines
blocked in GRPC client code. Our tctl tests create auth clients but
only expose them via auth.ClientI, which doesn't have a close method.

Updates #19372 and #24005
@github-actions github-actions bot requested review from nklaassen and r0mant April 3, 2023 20:33
@github-actions github-actions bot added backport size/sm tctl tctl - Teleport admin tool labels Apr 3, 2023
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from nklaassen April 3, 2023 20:53
@zmb3 zmb3 added this pull request to the merge queue Apr 3, 2023
Merged via the queue into branch/v12 with commit 1f8dfa8 Apr 4, 2023
@zmb3 zmb3 deleted the bot/backport-24011-branch/v12 branch April 4, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

Assignees
No one assigned
Labels
backport size/sm tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmb3 @r0mant @GavinFrazar