Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11] Prevent unknown ssh requests from terminating sessions #23905

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Mar 31, 2023

Backport #23874 to branch/v11

Note: This also reverts part of #23833 because it breaks backwards compatibility due to the server changes in #23874 not existing.

Instead of returning and aborting a session if an unknown request
is received servers now log the warning and continue on.
Because unknown session requests abort sessions instead of getting
rejected "envs@goteleport.com" breaks backwards compatability.
@rosstimothy rosstimothy force-pushed the bot/backport-23874-branch/v11 branch from 2c70c43 to a1fd7aa Compare March 31, 2023 16:36
@rosstimothy rosstimothy marked this pull request as ready for review March 31, 2023 17:09
@github-actions github-actions bot requested review from avatus and r0mant March 31, 2023 17:09
@rosstimothy rosstimothy enabled auto-merge March 31, 2023 17:50
@rosstimothy rosstimothy added this pull request to the merge queue Mar 31, 2023
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from avatus March 31, 2023 19:29
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2023
@rosstimothy rosstimothy added this pull request to the merge queue Mar 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2023
@rosstimothy rosstimothy added this pull request to the merge queue Mar 31, 2023
Merged via the queue into branch/v11 with commit fabbf1a Mar 31, 2023
@rosstimothy rosstimothy deleted the bot/backport-23874-branch/v11 branch March 31, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants