Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update kubeconfig if the proxy supports Kubernetes. #2364

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Only update kubeconfig if the proxy supports Kubernetes. #2364

merged 2 commits into from
Nov 14, 2018

Conversation

russjones
Copy link
Contributor

Purpose

Don't update kubeconfig if Teleport is not running as a Kubernetes proxy.

Implementation

  • Upon login, the Teleport client is updated with the address the Kubernetes proxy can be reached at. If this value is not set, don't update kubeconfig.

Related Issues

Fixes #2304

@russjones russjones requested a review from klizhentas November 14, 2018 00:52
@russjones russjones merged commit 8ce36a9 into master Nov 14, 2018
@russjones russjones deleted the rjones/kubeconfig-login branch November 14, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klizhentas klizhentas klizhentas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russjones @klizhentas