Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server access with PKINIT documentation page #23202

Merged
merged 18 commits into from
Apr 19, 2023

Conversation

gabrielcorado
Copy link
Contributor

@gabrielcorado gabrielcorado commented Mar 16, 2023

Related to #13837. Closes #18553.

Adds a guide on how to configure Microsoft SQL Server authentication with PKINIT. This page is separate from the other two SQL Server guides because it doesn't share setup steps.

This page shares some steps with Desktop Access (Manual). So some images are pointing to the desktop access folder.

Note: Currently, the database service configuration file is being used instead of the DB Configurator CLI command because it is missing some flags.

@ptgott
Copy link
Contributor

ptgott commented Mar 22, 2023

@gabrielcorado It looks like there were a couple of technical details to firm up in the docs, so please let me know when this is ready for a review of the writing. Thanks!

@gabrielcorado gabrielcorado requested a review from smallinsky April 3, 2023 21:18
@gabrielcorado
Copy link
Contributor Author

@ptgott This PR is ready for review. Thanks in advance.

@alexfornuto alexfornuto self-assigned this Apr 4, 2023
Copy link
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes


(!docs/pages/includes/install-linux.mdx!)

<Admonition type="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add to what Paul said, this statement could be read as implying that the Database service needs this package in general, and not specifically for this setup. And @ptgott, are we standardizing on a lower-case "service"?

@alexfornuto alexfornuto removed their assignment Apr 6, 2023
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor suggestions

@ptgott
Copy link
Contributor

ptgott commented Apr 7, 2023

Also @gabrielcorado is this a v13 feature?

@gabrielcorado
Copy link
Contributor Author

Also @gabrielcorado is this a v13 feature?

Yes, it is.

gabrielcorado and others added 2 commits April 10, 2023 11:20
@gabrielcorado
Copy link
Contributor Author

@smallinsky, Can you take a look? Thanks!

@gabrielcorado gabrielcorado enabled auto-merge April 19, 2023 18:06
@gabrielcorado gabrielcorado added this pull request to the merge queue Apr 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 19, 2023
@gabrielcorado gabrielcorado enabled auto-merge April 19, 2023 19:30
@gabrielcorado gabrielcorado added this pull request to the merge queue Apr 19, 2023
Merged via the queue into master with commit 57ef5a5 Apr 19, 2023
@gabrielcorado gabrielcorado deleted the gabrielcorado/sqlserver-pkinit-docs branch April 19, 2023 19:59
@public-teleport-github-review-bot

@gabrielcorado See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] SQLServer server access with pkinit x509 certs
4 participants