Build improvements #2306
Merged
Build improvements #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc25d17 to
58e117f
Compare
58e117f to
7afb95f
Compare
klizhentas
approved these changes
Oct 26, 2018
7afb95f to
32ea12a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow passing in the processor architecture as well as the Go runtime used to build Teleport releases.
Implementation
DockerfileandMakefileto support passing in of the processor architecture as well as Go runtime and use theses values to setup the environment correctly (pull down the correct runtime) as well as pass these flags to Go to build for the appropriate architecture.Related Issues
https://github.com/gravitational/teleport.e/pull/97