Add a guide to writing an Access Request plugin #22441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
reviewed
Mar 1, 2023
zmb3
reviewed
Mar 1, 2023
docs/pages/api/access-plugin.mdx
Outdated
| ```go | ||
| func (g *googleSheetsPlugin) makeRowData(ar types.AccessRequest) *sheets.RowData { | ||
|
|
||
| t := ar.GetCreationTime().String() |
There was a problem hiding this comment.
I find this hard to follow, since the variables have non-descriptive names and are used a dozen or so lines after they are declared.
How about a helper:
func stringPtr(s string) *string { return &s
Then you don't need these variables here and you inline them below.
UserEnteredValue: &sheets.ExtendedValue{
StringValue: stringPtr(ar.GetCreationTime().String()),
},
There was a problem hiding this comment.
Added for the one-line assignments. For the request state and link string, I used descriptive variable names instead.
a036718 to
6cc2f72
Compare
|
@alexfornuto This should be ready for a copy review |
Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets.
- Update the line of code count in the demo program - Mention Machine ID
6cc2f72 to
4c64f7c
Compare
alexfornuto
reviewed
Mar 8, 2023
alexfornuto
approved these changes
Mar 13, 2023
|
@hugoShaka @zmb3 Just checking to see if you were planning to give this another review. Thanks! |
hugoShaka
approved these changes
Mar 14, 2023
zmb3
approved these changes
Mar 14, 2023
|
@ptgott some misspellings here. I'll post in here the |
|
Spell fixes in #23068 |
ptgott
added a commit
that referenced
this pull request
Mar 14, 2023
* Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback
ptgott
added a commit
that referenced
this pull request
Mar 14, 2023
* Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback
ptgott
added a commit
that referenced
this pull request
Mar 15, 2023
* Add a guide to writing an Access Request plugin (#22441) * Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback * spell fixes plugin api docs (#23068) --------- Co-authored-by: Steven Martin <steven@goteleport.com>
ptgott
added a commit
that referenced
this pull request
Mar 15, 2023
* Add a guide to writing an Access Request plugin (#22441) * Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback * spell fixes plugin api docs (#23068) --------- Co-authored-by: Steven Martin <steven@goteleport.com>
ptgott
added a commit
that referenced
this pull request
Mar 16, 2023
* Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback
ptgott
added a commit
that referenced
this pull request
Mar 16, 2023
* Add a guide to writing an Access Request plugin (#22441) * Add a guide to writing an Access Request plugin Closes #22227 This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets. * Respond to hugoShaka feedback * Respond to zmb3 feedback * Add some minor tweaks - Update the line of code count in the demo program - Mention Machine ID * Respond to alexfornuto PR feedback * spell fixes plugin api docs (#23068) * Linter fixes --------- Co-authored-by: Steven Martin <steven@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22227
This guide uses a minimal working example of an Access Request plugin to demonstrate some of the key libraries that Teleport makes available to plugin developers. The guide is based on a 270-line plugin that manages Access Requests using Google Sheets.