Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Change #1928

Merged
merged 3 commits into from
May 4, 2018
Merged

Window Change #1928

merged 3 commits into from
May 4, 2018

Conversation

russjones
Copy link
Contributor

Purpose

As described in #1874 and #1910, Teleport has performance issues with window size changes and initial login when using DynamoDB as the backend.

Implementation

  • For window sizes changes, for regular sessions Teleport should propagate back the remote PTY size via a global SSH request from the server to the client. For sessions recorded at the proxy, nothing should be sent back because only the client can change the remote PTY size.
  • Use a cached copy of services.ClusterConfig within a context to reduce the number of requests to the backend (DynamoDB).
  • Improvements in lib/web so tests run consistently.
  • Create a single websocket between the browser and the proxy for all terminal bytes and events.

Related Issues

Fixes #1874
Fixes #1910

@russjones russjones force-pushed the rjones/window-change-2 branch 4 times, most recently from 3c9f939 to 60966ca Compare May 4, 2018 18:04
* Cache services.ClusterConfig within srv.ServerContext for the duration
  of a connection.
* Create a single websocket between the browser and the proxy for all
* terminal bytes and events.
@russjones russjones force-pushed the rjones/window-change-2 branch from 60966ca to 876e04a Compare May 4, 2018 18:28
@russjones russjones merged commit e225866 into master May 4, 2018
@russjones russjones deleted the rjones/window-change-2 branch May 4, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants