Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Generation Fixes #1686

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Key Generation Fixes #1686

merged 2 commits into from
Feb 16, 2018

Conversation

russjones
Copy link
Contributor

@russjones russjones commented Feb 15, 2018

Purpose

This PR resolves several issues. The fix for #1640 is uninteresting and #1638 no longer exists due to refactoring in #1679.

#1639 is the core of this PR. The native key generator has been updated to no longer be a singleton, the key pool size has increased, and the pool is used in the recording proxy (which leads to better performance when connecting to a proxy).

Implementation

  • Removed the singleton implementation of the native key generator. Instead a single key generator is created per Teleport process that is shared across the service.
  • The precomputed keys are now used in the recording proxy, this should decrease time to connect to a node the first time when using the recording proxy.
  • Due to the above, the size of the precomputed keys has increased from 10 to 25.

Related Issues

Fixes #1640
Fixes #1639
Fixes #1638

@russjones russjones requested a review from klizhentas February 15, 2018 00:39
Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keygen service should be called on service shutdown in lib/service/service.go then

@russjones russjones merged commit 3680326 into master Feb 16, 2018
@russjones russjones deleted the rjones/fix-races branch February 16, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in service package. Data race in auth package Data race in service package.
2 participants