tctl create improvements
#1266
Merged
tctl create improvements
#1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tctl create` used to create or update (AKA "upsert") resources. Now there's a difference: `--force, -f` flag, if not set, means "create only". Otherwise it means "update". This means you can fail updating non-existing resources.
russjones
approved these changes
Sep 6, 2017
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Now that clipboard.readText() requires transient user activation (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/readText#security), our system of syncing the local clipboard to remote onfocus and onmouseenter no longer works, since those events don't necessarily imply a transient event. With this change, we instead sendLocalClipboardToRemote onMouseDown and onKeyDown, which should guarantee that the sync is always within a transient event. Because the user must preform at least one of these actions in order to initiate a paste, the clipboard should appear to always be in sync from their perspective. * eliminates the entire useClipboard hook and its surrounding state, which was a big rube goldberg machine ensuring that 1. If a user had clipboard sharing enabled by RBAC 2. they were on chrome and 3. they had clipboard permissions allowed If 1 was true, but either of 2 or 3 wasn’t, we blocked the UI and forced them to correct it. That was also the mechanism that caused the clipboard permissions dialog to pop up at the beginning of the session if clipboard access wasn’t "granted". Now the UX is much simpler: if a user has clipboard sharing allowed by RBAC, and they’re on Chrome, clipboard sharing is enabled. If either of those is false, clipboard sharing is disabled. If a user’s clipboard permissions are in "prompt" state (aka neither "granted" nor "denied"), the first time they try to copy/cut something on the remote, or have something in their clipboard locally and click a mouse button or press a key, the browser prompt asking for clipboard permissions will show up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1137 (finally). Last bits:
tctl createworks on different resources for e vs OSStctl rmworks on different resources for e vs OSStctl createnow supports--force, -fflag for doing updatesAlso this PR fixes the build of
ewhich is currently broken due to failed merges in the past.Related: teleport.e/pull/12