Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Don't lint external links when running in CI #12058

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Apr 19, 2022

Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will check external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940

Original behaviour did not take effect in CI due to a different entrypoint.

Updates #11940
@webvictim webvictim self-assigned this Apr 19, 2022
@github-actions github-actions bot requested review from r0mant and zmb3 April 19, 2022 12:57
@webvictim webvictim enabled auto-merge (squash) April 19, 2022 12:57
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gus!

@webvictim webvictim merged commit 6090379 into master Apr 19, 2022
@webvictim webvictim deleted the gus/v9/docs-lint-external-fix branch April 19, 2022 16:00
webvictim added a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
@webvictim webvictim mentioned this pull request Apr 19, 2022
webvictim added a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
webvictim added a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
webvictim added a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
webvictim added a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
r0mant pushed a commit that referenced this pull request Apr 19, 2022
Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants