tctl refactoring #1168
Merged
tctl refactoring #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make the unit test more reliable refs #1143
`tctl` can now be compiled for multiple distributions, with different features (commands) enabled or disabled.
russjones
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This commit does not change any behavior. It is 100% refactoring and cleaning up. It prepares
tctlto exist in two forms (distributions):Meat
tctlalready had all of its commands separated into variousCommandstructures/classes. However, the CLI parsing (basicallymain()function) has been the same: big and flat, except it was calledRun()This commit makes
Run()configurable: a caller (usuallymain()) can pass a list of commands it wants to be executed. Obviously you can inherit commands as well.This allows different editions (distributions) of
tctlto be quickly created.Conclusion
This PR is a preparation for #1137 (becomes trivial)