Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax to respect TF minimum version (1.0.0) #11669

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

marcoandredinis
Copy link
Contributor

Most of the changes are related to the strictness of TF v0.12

https://www.terraform.io/language/upgrade-guides/0-12

Due to the design of the configuration language decoder in
Terraform v0.11 and earlier, it was in many cases possible to
interchange the argument syntax (with =) and the block syntax
(with just braces) when dealing with map arguments vs. nested
blocks. However, this led to some subtle bugs and limitations,
so Terraform v0.12 now requires consistent usage of argument
syntax for arguments and nested block syntax for nested blocks.

This commit validates both examples against Terraform 1

The min terraform version is going to be updated to 1.0.0
#11650

Fixes #11652

@github-actions github-actions bot requested review from r0mant and ravicious April 1, 2022 16:06
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch from 1340dba to 9d78197 Compare April 1, 2022 16:07
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but please wait for approval from @tcsc as well

@r0mant r0mant requested a review from tcsc April 1, 2022 18:32
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch 2 times, most recently from 6418174 to 7c1ef7b Compare April 5, 2022 08:06
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch from 7c1ef7b to cb8a1d2 Compare April 6, 2022 08:44
@marcoandredinis marcoandredinis requested review from tcsc and removed request for tcsc April 11, 2022 07:56
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch 2 times, most recently from 90f49e4 to 1edda03 Compare April 13, 2022 08:29
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch 6 times, most recently from c314323 to 2b03970 Compare April 14, 2022 15:11
@marcoandredinis marcoandredinis enabled auto-merge (squash) April 14, 2022 15:30
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch from 2b03970 to 2a2c986 Compare April 14, 2022 15:30
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch 3 times, most recently from 6b90ee8 to 9effa39 Compare April 14, 2022 22:07
@marcoandredinis marcoandredinis enabled auto-merge (squash) April 14, 2022 22:07
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch 2 times, most recently from 6136ba8 to 15d970a Compare April 15, 2022 09:37
Most of the changes are related to the strictness of TF v0.12

https://www.terraform.io/language/upgrade-guides/0-12
> Due to the design of the configuration language decoder in
> Terraform v0.11 and earlier, it was in many cases possible to
> interchange the argument syntax (with =) and the block syntax
> (with just braces) when dealing with map arguments vs. nested
> blocks. However, this led to some subtle bugs and limitations,
> so Terraform v0.12 now requires consistent usage of argument
> syntax for arguments and nested block syntax for nested blocks.

This commit validates both examples against Terraform 1

The min terraform version is going to be updated to 1.0.0
#11650

Fixes #11652
@marcoandredinis marcoandredinis force-pushed the marco/fix_docs_terraform_examples_syntax branch from 15d970a to fb8bb4d Compare April 15, 2022 09:38
@marcoandredinis marcoandredinis merged commit 6542531 into master Apr 15, 2022
@marcoandredinis marcoandredinis deleted the marco/fix_docs_terraform_examples_syntax branch April 15, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update terraform examples to match new syntax
4 participants