Fixed incorrectly named RPMs #11029
Merged
Fixed incorrectly named RPMs #11029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Mar 10, 2022
There was a problem hiding this comment.
@fheinecke Looks like this PR has more changes than needed. Can you rollback Makefile changes?
r0mant
reviewed
Mar 10, 2022
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
r0mant
approved these changes
Mar 10, 2022
russjones
approved these changes
Mar 10, 2022
wadells
approved these changes
Mar 10, 2022
zmb3
approved these changes
Mar 10, 2022
|
@fheinecke Can you also update PR description with a link to the test Drone build you ran to test this please. |
webvictim
approved these changes
Mar 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #11008 where RPMs would have "-centos7" appended to their filename. This prevented Houston from picking up the file and updating the download page correctly. This is the cause of https://goteleport.com/teleport/download/ for v9.0.0-rc.1 not listing an amd64 RPM. Tested the build produced by https://drone.platform.teleport.sh/gravitational/teleport/10735/13/8.