[v9] Handle case where display is itself a unix socket #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
approved these changes
Mar 9, 2022
| // It's possible that the display is actually the full path | ||
| // to an open XServer socket, such as with xquartz on OSX: | ||
| // "/private/tmp/com.apple.com/launchd.xxx/org.xquartz.com:0" | ||
| if d.HostName[0] == '/' { |
There was a problem hiding this comment.
Is DISPLAY guaranteed to be an absolute path, if it's a unix socket?
There was a problem hiding this comment.
I haven't found documentation about this, but based on the openssh code it looks like it has to be an absolute path ending with :display_num or :display_num.screen_num.
smallinsky
approved these changes
Mar 9, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10719