Fix missing identity in certs logic #10673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69ee54e to
16d8aff
Compare
4a443b5 to
c7871e3
Compare
rosstimothy
reviewed
Mar 1, 2022
jimbishopp
approved these changes
Mar 2, 2022
rosstimothy
reviewed
Mar 3, 2022
rosstimothy
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing identity in cert logic to only check if the roles extension is missing, rather than roles or traits. This logic was originally intended from discerning legacy certs from standard certs.
There are many supported use cases where traits will be nil in standard certs, such as in Teleport plugins where the user+role is created from a yaml file, and checking the roles alone is sufficient for differentiating legacy certs.
Closes #10081