Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the PATH variables from /etc/environment #1011

Closed
wants to merge 10 commits into from
Closed

Merge the PATH variables from /etc/environment #1011

wants to merge 10 commits into from

Conversation

jiangytcn
Copy link

Merge the PATH variables from login.def and /etc/environment

@gravitational-jenkins
Copy link

Can one of the admins verify this patch?

@russjones
Copy link
Contributor

Hi @jiangytcn, thanks for the PR! We had some internal discussion about this and unfortunately decided not to merge this PR.

This isn't the first time this has come up, we previously discussed it here: #945. As mentioned in the previous Issue, reading /etc/environment is typically handled by a PAM module. A while ago we decided not to support PAM #742, which is why even though we see value in reading /etc/environment we have not done it.

What we have done is implemented the equivalent of PermitUserEnvironment in OpenSSH: #1020. You can put the same values you have in /etc/environment in ~/.tsh/environment and start Teleport with the --permit-user-env flag to enable this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants