ENV_SUPATH from login.defs not used when connecting to root user #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
forgot to commit a line, patch should actually do what it says on the box now |
kontsevoy
requested changes
May 30, 2017
| defaultValue := "PATH=" + defaultPath | ||
| variableName := "ENV_PATH" | ||
| if osUser == "root" { |
There was a problem hiding this comment.
if root logs in without ENV_SUPATH defined, it won't pick up any path at all. instead, it should fall back to ENV_PATH in such case.
another question I have: is comparing username to root enough if a user is superuser? IMO a better test would be to check UID for 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a root user on Ubuntu (or any OS using login.defs) the ENV_SUPATH is used to set the default PATH variable value instead of ENV_PATH. Typically ENV_SUPATH has the sbin directories ENV_PATH does not.
This patch adds a username variable to the call of getDefaultEnvPath() and if it is root will load the ENV_SUPATH instead of ENV_PATH. This allows granting access to the root user directly while still providing the expected default PATH values.