Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ServerAliveInterval #963

Closed
russjones opened this issue May 1, 2017 · 0 comments
Closed

Support ServerAliveInterval #963

russjones opened this issue May 1, 2017 · 0 comments
Assignees
Milestone

Comments

@russjones
Copy link
Contributor

russjones commented May 1, 2017

OpenSSH allows setting ServerAliveInterval which sends a keepalive@openssh.com request at the configured interval:

https://github.com/openssh/openssh-portable/blob/master/clientloop.c#L480-L493

At the moment, Teleport ignores these requests:

https://github.com/gravitational/teleport/blob/master/lib/sshutils/server.go#L268-L276
https://github.com/gravitational/teleport/blob/master/lib/srv/sshserver.go#L623-L626

Instead Teleport always replies at it's own interval:

https://github.com/gravitational/teleport/blob/master/lib/sshutils/server.go#L259-L263
https://github.com/gravitational/teleport/blob/master/lib/sshutils/server.go#L285-L288

When OpenSSH doesn't get a response back, it kills the connection which ends up having the opposite result of what the user intended.

@russjones russjones self-assigned this May 1, 2017
@russjones russjones added this to the 2.1 milestone May 1, 2017
hatched pushed a commit that referenced this issue Feb 1, 2023
* autofill username if loggedInUser exists on cluster

* changed to loggedInUserName

* removing unneeded export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant