Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a non-UUID name for OpenSSH causes Web UI to not find node in inventory #50914

Closed
stevenGravy opened this issue Jan 9, 2025 · 0 comments · Fixed by #50915
Closed

Using a non-UUID name for OpenSSH causes Web UI to not find node in inventory #50914

stevenGravy opened this issue Jan 9, 2025 · 0 comments · Fixed by #50915
Assignees
@rosstimothy
Labels
bug OpenSSH For customers using Teleport and OpenSSH ssh

Comments

@stevenGravy
Copy link
Contributor

Expected behavior:

The node name could be both uuid and other strings w/o impacting access.

Current behavior:

Creating a node def with a non-UUID will make present an error like below when access is attempted.

kind: node
metadata:
  name: node-host-1
spec:
  addr: 192.168.1.108:22
  hostname: my-server
  rotation:
    current_id: ""
    last_rotated: "0001-01-01T00:00:00Z"
    schedule:
      standby: "0001-01-01T00:00:00Z"
      update_clients: "0001-01-01T00:00:00Z"
      update_servers: "0001-01-01T00:00:00Z"
    started: "0001-01-01T00:00:00Z"
  version: ""
sub_kind: openssh
version: v2

Image

Bug details:

  • Teleport version: 17.1.4
  • Recreation steps
  1. Define a node using a non-UUID metadata.name like above
  2. Attempt to access in the Web UI
@stevenGravy stevenGravy added bug OpenSSH For customers using Teleport and OpenSSH ssh labels Jan 9, 2025
@rosstimothy rosstimothy self-assigned this Jan 9, 2025
rosstimothy added a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
3576345 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
rosstimothy added a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
1c92537 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
@rosstimothy rosstimothy mentioned this issue Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name (#50915)
17edb10 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-actions bot pushed a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
fec49fe 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-actions bot pushed a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
d8284c9 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-actions bot pushed a commit that referenced this issue Jan 9, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
457f0ea 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
rosstimothy added a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
313c45f 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
rosstimothy added a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
b842105 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
rosstimothy added a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name
73b7e30 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name (#50925)
c20d654 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name (#50924)
2cf0f85 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@rosstimothy
Permit routing to agentless nodes with non-UUID metadata.name (#50926)
32ad497 
We suggest that a UUID is used for agentless nodes metadata.name
field, but we do not enforce it. This causes several edge cases
and slightly weird UX in places that expect the name to be a UUID.
Most notably, this presents dialing problems for the web ui as
described in #50914.
To allowing dialing to function in all cases for these servers,
routing has been updated to permit matches on metadata.name, however,
the match is given a lower score then a match on a UUID. This should
permit dialing, though, it may still result in ambiguity.

Closes #50914.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosstimothy rosstimothy

Labels
bug OpenSSH For customers using Teleport and OpenSSH ssh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Permit routing to agentless nodes with non-UUID metadata.name gravitational/teleport
2 participants
@rosstimothy @stevenGravy