Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error message when SAML provider is not sending attribute statements #1554

Closed
klizhentas opened this issue Jan 5, 2018 · 0 comments · Fixed by #1602
Closed
Assignees
Labels

Comments

@klizhentas
Copy link
Contributor

Description

When SAML provider is not sending any AttributeStatements (e.g. happens with Okta when groups are not mapped), logger outputs "missing AttributeStatement" to the logs that is not helpful.

Provide better error message to admins, with explicit request to map groups to attribute statements in UI.

@klizhentas klizhentas added the ux label Jan 5, 2018
@klizhentas klizhentas added this to the 2.5.0 milestone Jan 5, 2018
klizhentas added a commit that referenced this issue Jan 16, 2018
This commit fixes #1553, fixes #1554 and makes sure
that audit log contains login success and failure entries
for OIDC, SAML, Github and local logins.
@klizhentas klizhentas mentioned this issue Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants