Skip to content

Commit

Permalink
RDS Discover flows: mention VPC instead of region (#48792)
Browse files Browse the repository at this point in the history
RDS flows are now done using a single VPC.
  • Loading branch information
marcoandredinis authored Nov 12, 2024
1 parent f0a30b3 commit 3e06be0
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ export function AutoDiscoverToggle({
disabled={disabled}
>
<Box ml={2} mr={1}>
Auto-enroll all databases for the selected region
Auto-enroll all databases for the selected VPC
</Box>
<ToolTipInfo>
Auto-enroll will automatically identify all RDS databases (e.g.
PostgreSQL, MySQL, Aurora) from the selected region and register them
as database resources in your infrastructure.
PostgreSQL, MySQL, Aurora) from the selected VPC and register them as
database resources in your infrastructure.
</ToolTipInfo>
</Toggle>
</Box>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export function AutoEnrollment({
}
);

// Abort if there were no rds dbs for the selected region.
// Abort if there were no rds dbs for the selected region/vpc.
if (fetchedDbs.length <= 0) {
onFetchAttempt({ status: 'success' });
setTableData({ ...data, fetchStatus: 'disabled' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe('test EnrollRdsDatabase.tsx', () => {
fireEvent.keyDown(selectEl, { key: 'ArrowDown' });
fireEvent.keyDown(selectEl, { key: 'Enter' });

await screen.findByText(/selected region/i);
await screen.findByText(/selected VPC/i);
}

test('without rds database result, does not attempt to fetch db servers', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export function SingleEnrollment({
}
);

// Abort early if there were no rds dbs for the selected region.
// Abort early if there were no rds dbs for the selected region/vpc.
if (fetchedDbs.length <= 0) {
onFetchAttempt({ status: 'success' });
setTableData({ ...data, fetchStatus: 'disabled' });
Expand Down

0 comments on commit 3e06be0

Please sign in to comment.