Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docusaurus to 3.5 #2

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Oct 24, 2024

@ptgott ptgott requested a review from mmcallister October 24, 2024 14:17
@ptgott
Copy link
Contributor Author

ptgott commented Oct 24, 2024

@mmcallister Would you have time to give this one a look? It fixes issues that break Docusaurus preview builds. Thanks!

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2.d2mrezcly5gcqm.amplifyapp.com

Copy link
Contributor

@taraspos taraspos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptgott it seems like both v16 and v17 versions are pointing at master branch. I think that might be a mistake.

docs-website/config.json

Lines 71 to 80 in 7fe1582

{
"name": "16.x",
"branch": "master",
"latest": true
},
{
"name": "17.x",
"branch": "master",
"current": true
}

- Upgrade Docusaurus packages to `^3.5.0`
- Fix `@theme/Unlisted` import, since the module declaration was changed
  in facebook/docusaurus#10376.
- Update imports to reflect the movement of some exports from
  `@docusaurus/theme-common/internal` into
  `@docusaurus/plugin-content-docs/client`. See
  facebook/docusaurus#10316.

Also updates config.json to correct branch names.
@ptgott ptgott force-pushed the paul.gottschling/2024-10-24-fix-build branch from de27da8 to c53ffa3 Compare October 24, 2024 16:10
@mmcallister mmcallister merged commit d13c30b into main Oct 24, 2024
4 checks passed
@mmcallister mmcallister deleted the paul.gottschling/2024-10-24-fix-build branch October 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants