Skip to content

Commit

Permalink
Adding @todos. (acquia#1684)
Browse files Browse the repository at this point in the history
* Fixing issue preventing Behat tests from running on ci.

* Importing features after site installation.

* Adding @todos.

* PHPCS.
  • Loading branch information
grasmash authored Jun 16, 2017
1 parent 133d62e commit af72d4b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/travis/run_tests
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ yaml-cli update:value blt/project.yml project.local.hostname '127.0.0.1:8888'

blt validate:all
blt setup -D drush.alias='${drush.aliases.ci}' --no-interaction
blt tests:all --define tests.run-server=true --yes -v
blt tests:all drush.alias='${drush.aliases.ci}' --define tests.run-server=true --yes -v

set +v
1 change: 1 addition & 0 deletions src/Robo/Commands/Blt/UpdateCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ protected function executeSchemaUpdates($starting_version) {
if ($updates) {
$this->say("<comment>The following BLT updates are outstanding:</comment>");
$updater->printUpdates($updates);
// @todo Do not prompt if this is being run from Plugin.php.
$confirm = $this->confirm('Would you like to perform the listed updates?');
if ($confirm) {
try {
Expand Down
2 changes: 1 addition & 1 deletion src/Robo/Commands/Setup/BuildCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function setup() {
public function drupalInstall() {
$commands = ['internal:drupal:install'];
$strategy = $this->getConfigValue('cm.strategy');
if ($strategy == 'config-split') {
if (in_array($strategy, ['config-split', 'features'])) {
$commands[] = 'setup:config-import';
}

Expand Down
3 changes: 3 additions & 0 deletions src/Robo/Exceptions/BltException.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ public function __construct(
$code = 0,
\Throwable $previous = NULL
) {

// @todo Check verbosity level. If not verbose, append "Re-run the command
// with -v to see more verbose output."
parent::__construct($message, $code, $previous);

$this->transmitAnalytics();
Expand Down

0 comments on commit af72d4b

Please sign in to comment.