Make 'errors' top property in the response object. #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm into it. Good idea |
IvanGoncharov
added a commit
to IvanGoncharov/graphql
that referenced
this pull request
Nov 21, 2017
To reflect change from graphql/graphql-js#838
leebyron
pushed a commit
to graphql/graphql-spec
that referenced
this pull request
Nov 29, 2017
* Change order of fields inside Response To reflect change from graphql/graphql-js#838 * Update Section 7 -- Response.md Remove "first" and "next" and include an explicit note about errors appearing first when serialized as a convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s hard to notice
errorsproperty if it is hidden under multiple screens of JSON.For example, if you run this query you will see the following:
And only if you scroll a couple pages down you will see an error what is bad DX.
To fix this I just changed the order of
errorsanddatafields so result of the same query look like this: