Backport instanceOf Error Check Improvements #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
|
@IvanGoncharov does this look ok to you? |
This backports graphql#3172 to the `15.x.x` branch so that users of GraphQL v15.x can take advantage of it. GraphQL v16.x has some breaking changes and is not possible to run when you have other libraries depending on the behavior of v15, such as GraphQL Code Generator.
4fdaade to
7b724c7
Compare
|
@tubbo Thanks, super useful 👍 |
|
Yay, thanks @tubbo and @IvanGoncharov! |
benjamn
pushed a commit
to apollographql/react-apollo-error-template
that referenced
this pull request
Jun 23, 2021
Includes @benjamn's PR graphql/graphql-js#3172, backported to 15.5.1 by graphql/graphql-js#3186.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #3172 to the
15.x.xbranch so that users of GraphQLv15.x can take advantage of it. GraphQL v16.x has some breaking changes
and is not possible to run when you have other libraries depending on
the behavior of v15, such as GraphQL Code Generator.