Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

77 Errors with Flow 0.27. #418

Closed
iamchenxin opened this issue Jul 1, 2016 · 1 comment
Closed

77 Errors with Flow 0.27. #418

iamchenxin opened this issue Jul 1, 2016 · 1 comment

Comments

@iamchenxin
Copy link
Contributor

I find something strange.
Like uildASTSchema.js#L338:

  function makeImplementedInterfaces(def: ObjectTypeDefinition) {
    return def.interfaces.map(inter => produceTypeDef(inter));
  }

which def.interfaces is interfaces?: ?Array<NamedType> (defined in ast.js#L296 )
Seems flow 0.26 should give an error on those,but it shouldn't.

@iamchenxin
Copy link
Contributor Author

iamchenxin commented Jul 2, 2016

Fixed these errors in PR #420 .

leebyron added a commit that referenced this issue Jul 6, 2016
flow check now passes for the existing v0.26 as well as v0.27 and v0.28, so upgrading to the latest version.

Fixes #412, #418, #420
@leebyron leebyron closed this as completed Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants