chore: support graphql-js@16 #1983
Conversation
|
| const deprecationWarningAnnotations = mapCat( | ||
| findDeprecatedUsages(schema, ast), | ||
| validate(schema, ast, [NoDeprecatedCustomRule]), |
There was a problem hiding this comment.
this change will require us to depend on graphql@15.4.2 ? or later
There was a problem hiding this comment.
| @@ -37,6 +37,7 @@ function createEditorWithHint() { | |||
| return CodeMirror(document.createElement('div'), { | |||
| mode: 'graphql', | |||
| hintOptions: { | |||
| hint: true, | |||
There was a problem hiding this comment.
@acao Is it related to graphql@16?
It looks like it causes this error:
https://github.com/graphql/graphiql/runs/3892946205?check_suite_focus=true#step:5:28
|
closing for #1988 |
This is just a start on upgrading to graphql-js@16!
Typescript builds, there are just some issues with tests now... potentially regressions?
TODO:
@deferand@streambuilt-in directives are missing from autocompletion unit tests, so we might need to switch to thegraphql@16.0.0-rc.4-experimental-stream-defertagmergeASTcypress tests are expecting a newline at the end that isn't there anymore due to a breaking change across versionsincrementalDeliverycypress test is failing because no@deferor@streamis present