Decouple object safe part from GraphQLType #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the perf noticeable switching from static to dynamic dispatch? |
|
@LegNeato we do not switch from static to dynanic dispatch in this PR. This PR touches nothing perf-related. It just refactors traits definitions in the way making dynamic dispatch possible to use in future. Current |
|
Apologies, hadn't looked at the code yet :-) |
LegNeato
approved these changes
Jun 29, 2020
# Conflicts: # juniper/CHANGELOG.md
a6bbe78 to
af26c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revealed from #682
Required for #682
Overview
Decouples object safe part of
GraphQLTypetrait into a separateGraphQLValuetrait. Does the same forGraphQLTypeAsyncandGraphQLSubscriptionTypetoo.Motivation
This change allows to use dynamic dispatch via resolving
GraphQLValuetrait objects.