Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch delegation collapses two requests with different arguments into a single memoized loader #382

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Dec 26, 2024

Originally fixed by @maxbol in the PR ardatan/graphql-tools#5189

Closes #5188
Fixes #5189

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.26-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 3.0.5-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.10.25-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.7.4-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.32-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.20-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.4.4-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.4.12-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2 npm ↗︎ unpkg ↗︎

@ardatan ardatan requested a review from Urigo December 26, 2024 12:58
@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.7.4-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.7.4-alpha-9c41cde1c216af298b0d06bac70cea796d4f03e2-bun

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 26, 2024

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@maxbol
Copy link

maxbol commented Dec 26, 2024

Huge thank you to @ardatan for having a look at this! Corner case, but this means we can stop maintaining our own fork of the batch-delegation library. 🥳

@ardatan ardatan merged commit 21e1f05 into main Dec 26, 2024
36 checks passed
@ardatan ardatan deleted the fix-batched-args branch December 26, 2024 19:38
@ardatan
Copy link
Member Author

ardatan commented Dec 26, 2024

Thank you for the PR again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch delegation memoization is insensitive to non-key arguments
4 participants