-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enhance: better debug messages for readiness check endpoint (#356)
- Loading branch information
Showing
2 changed files
with
35 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
--- | ||
'@graphql-hive/gateway-runtime': patch | ||
--- | ||
|
||
Better messages on debug logs of readiness check endpoint; | ||
|
||
Before; | ||
On successful readiness check, the gateway was logging the following message: | ||
``` | ||
Readiness check passed: Supergraph loaded | ||
``` | ||
Because this makes the users think it was just loaded. | ||
After; | ||
On successful readiness check, the gateway will log the following message: | ||
``` | ||
Readiness check passed because supergraph has been loaded already | ||
``` | ||
|
||
On failed readiness check, the gateway was logging the following message: | ||
Before; | ||
``` | ||
Readiness check failed: Supergraph not loaded | ||
``` | ||
It should make the users think it was not loaded or there is an issue with the supergraph. | ||
|
||
After; | ||
``` | ||
Readiness check failed because supergraph has not been loaded yet or failed to load | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters