This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
numbers: Add proper safety to operator overloading #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssemblyScript (
0.19.10
) has a bug that allows operator overloading functions to be called with nullable values only when they are class properties, like this:To fix this, we must change the type signature of the operator overloading methods, like this:
I would like to write a test for each of these operator overloading changes, however it would be very difficult to test, since I would have to mock the host-exports function for each of them (implemented in the Rust/graph-node side).
Related PR in
graph-node
: graphprotocol/graph-node#2780