Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subgraph composition spec version #5782

Open
wants to merge 4 commits into
base: zoran/subgraph-composition-rework-vid-wrap2
Choose a base branch
from
Open

Subgraph composition spec version #5782

wants to merge 4 commits into from

Conversation

zorancv
Copy link
Contributor

@zorancv zorancv commented Jan 23, 2025 •
edited
Loading

This PR aims to base VID generation on spec_version so that both old and new way of generating VID will work simultaneously in the single binary. Some code that was removed in #5737 is reintroduced here.

@zorancv zorancv self-assigned this Jan 23, 2025
@zorancv zorancv changed the base branch from master to zoran/subgraph-composition-rework-vid-wrap2 January 23, 2025 16:23
@zorancv zorancv marked this pull request as ready for review January 23, 2025 16:29
@zorancv zorancv marked this pull request as draft January 23, 2025 16:30
@zorancv zorancv changed the base branch from zoran/subgraph-composition-rework-vid-wrap2 to zoran/rename-structs January 27, 2025 16:21
@zorancv zorancv changed the base branch from zoran/rename-structs to zoran/subgraph-composition-rework-vid-wrap2 January 27, 2025 16:24
@zorancv zorancv marked this pull request as ready for review January 27, 2025 16:56
@zorancv zorancv requested a review from lutter January 27, 2025 16:56
@zorancv zorancv marked this pull request as draft January 28, 2025 15:46
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 6 times, most recently from d8bea9d to 47176c8 Compare January 28, 2025 22:20
@zorancv zorancv marked this pull request as ready for review January 28, 2025 23:52
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 2 times, most recently from 81f0a57 to 133169c Compare January 29, 2025 00:04
@zorancv zorancv force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch 4 times, most recently from 961556b to a49edb8 Compare January 29, 2025 16:35
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch from 133169c to 6cb3a0c Compare January 29, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter Awaiting requested review from lutter

Assignees

@zorancv zorancv

Labels
composition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zorancv