Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct store when loading indexes for graft base #5616

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

encalypto
Copy link
Contributor

Previously, we were trying to load indexes from the store corresponding to the subgraph being deployed. This was the wrong shard, resulting in deployment failures when a subgraph is on a different shard from its graft based.

This updates the call to use the correct store.

@encalypto encalypto marked this pull request as ready for review August 21, 2024 17:02
@encalypto encalypto requested a review from zorancv August 21, 2024 17:02
Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@yash251
Copy link
Member

yash251 commented Aug 28, 2024

Any timeline for when this will be merged and released?

@encalypto encalypto merged commit 9a51f3b into master Aug 28, 2024
7 checks passed
@encalypto encalypto deleted the fix-grafting-connection-shard branch August 28, 2024 17:14
@encalypto
Copy link
Contributor Author

@yash251

Any timeline for when this will be merged and released?

Confirming this has been released to production, and deploying grafts now works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants