Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Allow grafts to add data sources (#3989)" #4026

Closed
wants to merge 1 commit into from
Closed

Revert "fix: Allow grafts to add data sources (#3989)" #4026

wants to merge 1 commit into from

Conversation

leoyvens
Copy link
Collaborator

@leoyvens leoyvens commented Oct 4, 2022 •
edited
Loading

This reverts commit 3b3b458. It's causing existing grafted subgraphs to stop indexing.

Just the migration to add the raw_yaml colum is kept.

@leoyvens leoyvens mentioned this pull request Oct 4, 2022
Merged
@leoyvens
Copy link
Collaborator Author

leoyvens commented Oct 4, 2022

After #4027 hopefully this won't be necessary.

@leoyvens leoyvens closed this Oct 4, 2022
@leoyvens leoyvens force-pushed the leo/revert-allow-graft-to-add branch from 90f4e5e to 0c4417e Compare October 4, 2022 12:03
@leoyvens leoyvens reopened this Oct 4, 2022
@leoyvens leoyvens force-pushed the leo/revert-allow-graft-to-add branch from aba4f07 to eb49180 Compare October 4, 2022 12:07
@leoyvens
Copy link
Collaborator Author

leoyvens commented Oct 4, 2022

This was fixed without the need of a revert.

@leoyvens leoyvens closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leoyvens