Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firehose: Dont use debug format on firehose errors #3990

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

leoyvens
Copy link
Collaborator

This would print the error with newlines, the best is to use {:#} to print with causes.

@leoyvens leoyvens requested a review from lutter September 26, 2022 15:00
@maoueh
Copy link
Contributor

maoueh commented Sep 27, 2022

Merging right away.

@maoueh maoueh merged commit 750730c into master Sep 27, 2022
@maoueh maoueh deleted the leo/dont-use-debug-format-on-anyhow-error branch September 27, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants