Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON type serialization #121

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Fix JSON type serialization #121

merged 1 commit into from
Sep 21, 2016

Conversation

calebmer
Copy link
Collaborator

JSON objects have been serializing incorrectly. This has been mentioned a couple of times like in #116 or #102.

This fixes the problem, but still doesn’t add arbitrary JSON to the tree as is advocated in #102 👍

This was referenced Sep 21, 2016
Copy link
Contributor

@ferdinandsalis ferdinandsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@calebmer calebmer merged commit dff9f23 into master Sep 21, 2016
@calebmer calebmer deleted the fix/json-type branch September 21, 2016 19:44
@valoricDe
Copy link
Contributor

I am still encountering the "False boolean values always null" / unknown. But I'm already on newest master (2.3.0 I guess). 😢 Anything I could check? function public.upsert_vote(integer, integer, integer, unknown) does not exist" whereas the unknown is the false value.

@benjie
Copy link
Member

benjie commented Nov 15, 2016

@Valorize: are you using the dynamicJson setting? Can you come up with a minimal test case (i.e. schema, query and variables) that reproduces the issue?

@benjie
Copy link
Member

benjie commented Nov 15, 2016

Or, even better would be if you could reproduce it using one of the postgraphql tests - that way we can prevent it from happening again in future 👍

@valoricDe
Copy link
Contributor

@benjie Good idea. Which parameters do I have to supply to $npm_bin/jest $@?

@benjie
Copy link
Member

benjie commented Nov 18, 2016

@Valorize Check out the CONTRIBUTING.md file for instructions - let me know if that doesn't cover your questions as one of my missions is to improve developer onboarding to PostGraphQL 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants