Feature/bring upstream changes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix spinner overflow with padding * spinner TagName determines both elements * revert css change * Compute viewbox such that stroked track sits exactly at edge of image frame * add viewbox test
…ed (palantir#2988) * newly focused cell after keyboard navigation is now transformed, fixes palantir#2871 * removed unnecessary tslint directive * selectedRegionTransform() may return a new region so forEach() is not enough * ISelectedRegionTransform now also accepts keyboard events
* first pass at creating a small sized InputGroup * fixing a couple more things in the example * fixing linting issues and various other misc issues that @giladgray pointed out * adding a bp3-tag inside of small input css rule, fixing missing scss variable error * adding bp3-tag rule to _input.scss * fixing input-small padding issues; adding css input small examples * fixing weird linting issue.. * making padding rely on pt-grid-size instead of a hardcoded variable * adding a input-small-padding variable and updating to use the new variable * switching a couple scss variables
* Utils.isElementOfType checks displayName equality to support multiple minor versions * MultiSliderHandle add displayName * refactor Tabs to use type guard for children * fix Tabs type guard * add displayName fields to some Table components * oops lint
* Create a fixer for classes-constants lint rule 1. The lint rule will now fail the entire node, instead of just the pt-* string 2. The lint rule now has a fixer that will replace the pt-* string with the blueprint import * PR comments * Add DOM library to make compile work without skipLibCheck * Undo regression to tslint error reporting
* complete refactor to tests with a sweet harness * add onOverflow callback prop & isResizing state & test. * short example crumbs so they can all be visible * only invoke onOverflow when items change added some state fields to support this logic. complex stuff as it can happen over several renders. * more onOverflow tests & helper * more docs, combine if * reset lastOverflow with new props * simplify lastOverflow check - just length * lastOverflowCount defaults to 0 * fix name in comment
* [Tag] don't render text if no children * add tests
* pull string literal replacement logic to separate function much more legible, only one push(). add doc comments. * further refactor into two helper methods replacement logic is dead simple now * remove a helper function * deconstruct, pattern at the top * small edits * amend regex to ignore pt-icon strings * pull out match iteration logic
* adjust new variables * fix font icons in input-groups * fix small round padding * refactor textarea styles, add small prop to component
* move example tooltip * proper icon color, including in secondary label * remove unnecessary color rule * use chevron instead of caret * center popover wrappers/targets in secondary label * scope icon color * fix caret styles for SVGs. style the Icon component directly. * maybeRenderCaret, fix no-caret width * test refactors * remove line-height
* lint bp3- prefix too * merge multiple spaces in stringWithoutPtClasses * add some bp3 tests * found a lint failure!
* edit icons docs, add example * refactor docs icons: sort icons within groups * Radial => Circle icon displayName
…feature/bring-upstream-changes
|
I would squash these changes into a single commit |
|
Have you bring already released changes or are you getting them from deploy? I'm fine with the changes. |
|
I brought those changes from |
|
So this PR merge commits that are newer than |
|
@crispamares see https://github.com/graphext/graphext/pull/165 |
|
@crispamares we won't have problems because these are the changes after published version:
Then, there aren't changes in the packages we are using: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crispamares here I put a summary of changes comming from upstream (version blueprintjs/core@3.7.0).
### Main changes:
Anyhow, I think it does not includes performance changes but just makes the spinner fits the image frame...