reverse order of errors vs data in response #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetcher
approved these changes
Sep 22, 2018
|
Thanks for the contribution! |
pavelnikolov
requested changes
Oct 2, 2018
pavelnikolov
approved these changes
Oct 2, 2018
tinnywang
pushed a commit
to tinnywang/graphql-go
that referenced
this pull request
Dec 13, 2018
reverse order of errors vs data in response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I moved the errors field before the data field in the response object based on the recommendation of the graphql standard merged in this pr: graphql/graphql-spec#384