Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for conversations 2.0 #1147

Open
wants to merge 105 commits into
base: main
Choose a base branch
from
Open

Add docs for conversations 2.0 #1147

wants to merge 105 commits into from

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented Nov 9, 2024 •
edited
Loading

Adds all docs for conversations 2.0.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024 •
edited
Loading

🚀 Deployed on https://6797e88615fb115996ce4ce6--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 9, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 9, 2024 15:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 9, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 9, 2024 22:34 Inactive
@KnorpelSenf KnorpelSenf changed the title Add first half of docs for conversations v2.x Add most of the docs for conversations v2.x Nov 10, 2024
@github-actions github-actions bot temporarily deployed to pull request November 10, 2024 08:48 Inactive
@KnorpelSenf KnorpelSenf mentioned this pull request Nov 10, 2024
Closed
@github-actions github-actions bot temporarily deployed to pull request November 10, 2024 23:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 11, 2024 00:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 11, 2024 00:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 01:01 Inactive
@KnorpelSenf
Copy link
Member Author

KnorpelSenf commented Jan 13, 2025 •
edited
Loading

@LWJerri is Ukrainian ready now? Should we add the label?

@niusia-ua
Copy link
Member

niusia-ua commented Jan 13, 2025 •
edited
Loading

@KnorpelSenf We are also waiting for the review from @deptyped, who should have done it soon.

@github-actions github-actions bot temporarily deployed to pull request January 13, 2025 17:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 13, 2025 17:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 10:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 10:37 Inactive
deptyped
deptyped requested changes Jan 15, 2025
View reviewed changes
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
site/docs/uk/plugins/conversations.md Outdated Show resolved Hide resolved
@niusia-ua @deptyped
Apply suggestions from code review
ce50e3a 
Co-authored-by: deptyped <deptyped@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 09:20 Inactive
@KnorpelSenf
Copy link
Member Author

Some anchors are still off for UK

@KnorpelSenf
Copy link
Member Author

Also, should all the outdated suggestions above be resolved?

@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 09:25 Inactive
@niusia-ua
Copy link
Member

niusia-ua commented Jan 16, 2025 •
edited
Loading

@KnorpelSenf I fixed links and resolved comments.

@niusia-ua niusia-ua requested a review from deptyped January 16, 2025 09:27
@niusia-ua niusia-ua added the 🇺🇦 UK Modifies or is related to the Ukrainian translations. label Jan 16, 2025
@KnorpelSenf
Copy link
Member Author

Yay! We're so close

@github-actions github-actions bot temporarily deployed to pull request January 17, 2025 08:47 Inactive
@agoudbg agoudbg mentioned this pull request Jan 24, 2025
Merged
@agoudbg @KnorpelSenf
Conversations 2.0 Chinese (#1182)
8043fa1 
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request January 24, 2025 10:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 27, 2025 20:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niusia-ua niusia-ua niusia-ua approved these changes

@quadratz quadratz quadratz approved these changes

@LWJerri LWJerri LWJerri approved these changes

@rojvv rojvv rojvv approved these changes

@habemuscode habemuscode habemuscode approved these changes

@deptyped deptyped deptyped approved these changes

@KnightNiwrem KnightNiwrem Awaiting requested review from KnightNiwrem

Assignees
No one assigned
Labels
🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. merge on release ready for translation Translator intervention is required. 🇷🇺 RU Modifies or is related to the Russian translations. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.