-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add scrollbar to the side navigation menu #1346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
Documentation/_static/css/gramine.css
line 8 at r1 (raw file):
.wy-side-scroll { width: auto; overflow-y: auto;
why not overflow-y: scroll
?
Code quote:
auto
Co-authored-by: Deb Taylor <deb.taylor@intel.com> Co-authored-by: Paul Cartee <paulx.alan.cartee@intel.com> Co-authored-by: Benny Fuhry <benny.fuhry@intel.com> Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com> Signed-off-by: Deb Taylor <deb.taylor@intel.com> Signed-off-by: Paul Cartee <paulx.alan.cartee@intel.com> Signed-off-by: Benny Fuhry <benny.fuhry@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
-- commits
line 2 at r1:
[Docs] Add scrollbar to the side navigation menu when content overflows
Code quote:
[Docs] Add scrollbar to the side navigation menu
Documentation/_static/css/gramine.css
line 8 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
why not
overflow-y: scroll
?
UPDATE: OK I see, with auto
, the scroll bar'll be displayed only if the content is overflowing (i.e., if content fits inside the element's padding box, it looks the same as with visible
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)
Documentation/_static/css/gramine.css
line 8 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
why not
overflow-y: scroll
?
But why? auto
seems like a meaningful default (only show the scrollbar when the table of contents really overflows).
For details, one can check https://www.w3schools.com/cssref/css3_pr_overflow-y.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
Documentation/_static/css/gramine.css
line 8 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
But why?
auto
seems like a meaningful default (only show the scrollbar when the table of contents really overflows).For details, one can check https://www.w3schools.com/cssref/css3_pr_overflow-y.php
Yes, auto
makes better sense.
ccb6572
to
0dfa466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
Previously, kailun-qin (Kailun Qin) wrote…
[Docs] Add scrollbar to the side navigation menu when content overflows
Done (removed the
to make the title char size smaller)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
Jenkins, retest check-python-platlib please (internet connectivity problems) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Description of the changes
Extracted from #1241.
How to test this PR?
I created a RTD job to see the rendering: https://gramine.readthedocs.io/en/dimakuv-docs-add-sidebar-gramine-css/. Notice the scrollbar. Compare with our classic: https://gramine.readthedocs.io/
This change is