This repository was archived by the owner on Mar 10, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 35
#13552 Integrate grails-web-testing-support from grails/grails-testing-support into grails-gsp #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rails#285) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ils#292) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
grails#291) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…s#290) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ls#293) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update grails monorepo to v6.0.0-RC1 * Downgrade Test project to Grails 6.0.0-M4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Puneet Behl <behlp@objectcomputing.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…11.1 (grails#296) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(deps): update dependency org.springframework.boot:spring-boot-test to v3.4.0
fix(deps): update dependency org.springframework:spring-test to v6.2.0
Update to asset pipeline 5.0.4 by using version from grails-bom
… prevent circular reference
Pre release workflow support & removing async from testing support to…
back to snapshot of grails-core
fix docs task by adding grails-bom
jamesfredley
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7292f57 looks good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/grails-core#13552 The merge for https://github.com/grails/grails-testing-support is split across these repositories:
Note: grails-web-testing-support may need further as part of any gsp clean-up or independence, but the main issue is the taglib logic lives in this project and the web functionality under test lives across this project + grails-core. We can't push that logic down to core since there will be a circular dependency causing publish problems. Ideally, we would push the controller / interceptor test logic to core, but taglibs & rendering can be called from controllers. it also doesn't make sense to be in grails-views project because that's for other view technology - while the grails-web-testing-support is specifically for taglibs, gsp, etc