Skip to content
This repository was archived by the owner on Mar 10, 2025. It is now read-only.

Removed marked for removal #515

Open
wants to merge 1 commit into
base: 7.0.x
Choose a base branch
from

Conversation

codeconsole
Copy link
Contributor

@codeconsole codeconsole commented Oct 16, 2024

@matrei any idea what is going on here?

@matrei
Copy link
Contributor

matrei commented Nov 5, 2024

@codeconsole Looking at the comment in the code, It looks like there was a problem with the src/main/resources/META-INF/grails.factories file being overridden by a version generated by the compileGroovy task.

So, apparently a grails.factories file is generated by the compileGroovy task and this workaround directly deletes it so it does not override the one in src.

Looking a the "Remove after 5.0.0.M2" TODO, it seems that this commit is meant to fix this, but the workaround here was never removed.

Maybe the fix, didn't work, or it was just forgotten to remove the workaround.
I'll try out the code later to see what it does.

@jdaugherty
Copy link
Contributor

When I tested this, removing this causes it to still fail. I had to leave these in the gradle files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants