-
Notifications
You must be signed in to change notification settings - Fork 43
Fix interacting with an element inside nested IFrames #1096
Conversation
We would very much like this fix to be merged in the next release because as of now our test-script for our customer's behalf cannot run fully to the end. Thank you kindly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! LGTM.
Just one request, which is to tidy up the test.
EDIT: Can you please squash the two commits which are related to the test.
e18e748
to
a86bd4b
Compare
a86bd4b
to
7ca6bde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for this 🙇 Can you also rename the first commit to: Fix getFrameElement to find root frame
? One more suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 🙇 Please remember to rename the first commit to: Fix getFrameElement to find root frame
.
1087-getFrameElement
Co-authored-by: Ankur <akahank@gmail.com>
2438d02
to
4eef973
Compare
@bandorko I've amended the commit message that @inancgumus was suggesting. I'll be merging this change in once the CI pipeline passes. |
What?
Page.getFrameElement
now finds the root frame. Only the root frame has aFrameSession
.Why?
With k6 v0.47.0 github.com/grafana/xk6-browser@v1.1.0/common/page.go:274 panicked because the parent session was nil.
Checklist
Related PR(s)/Issue(s)
Closes: #1087