Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to distributor to push tempopb.Trace #4494

Closed
wants to merge 1 commit into from

Conversation

yvrhdn
Copy link
Member

@yvrhdn yvrhdn commented Dec 26, 2024

What this PR does:

Adds a new endpoint to the distributor that accepts tempopb.Trace directly.

This makes it possible to push tempopb directly without passing through the OTel Collector receiver. It avoids work associated with converting ptrace.Traces to tempopb.Trace.

I have also extended tempopb/trace_utils.go with handy functions to count spans in a trace and to convert tempopb to OTLP and back.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yvrhdn
Copy link
Member Author

yvrhdn commented Dec 27, 2024

I think the idea of adding an endpoint for pushing tempopb directly is fine, but if we have otlp converting it to tempopb to send it ends up being the same work, just in a different place.

@yvrhdn yvrhdn closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant