Update architecture.md #4475
Merged
Update architecture.md #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Clarified the querier's role in querying both ingesters and backend storage. Also, Improved grammar and rephrased.
javiermolinar
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
I'm good with this, but I would like @knylander-grafana to double check
knylander-grafana
approved these changes
Jan 7, 2025
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Update architecture.md Hi, Clarified the querier's role in querying both ingesters and backend storage. Also, Improved grammar and rephrased. * Apply suggestions from code review --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 0ec6d08)
3 tasks
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4475-to-release-v2.7 origin/release-v2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0ec6d085722b270de1c93939a10dc477183881f5When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-4475-to-release-v2.7
# Create the PR body template
PR_BODY=$(gh pr view 4475 --json body --template 'Backport 0ec6d085722b270de1c93939a10dc477183881f5 from #4475{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release-v2.7] Update architecture.md' --body-file - --label 'type/docs' --label 'backport' --base release-v2.7 --milestone release-v2.7 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-4475-to-release-v2.7
# Create a pull request where the `base` branch is `release-v2.7` and the `compare`/`head` branch is `backport-4475-to-release-v2.7`.
# Remove the local backport branch
git switch main
git branch -D backport-4475-to-release-v2.7 |
electron0zero
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Update architecture.md (#4475) * Update architecture.md Hi, Clarified the querier's role in querying both ingesters and backend storage. Also, Improved grammar and rephrased. * Apply suggestions from code review --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit 0ec6d08) * Update docs/sources/tempo/operations/architecture.md --------- Co-authored-by: Ali <115415312+xogoodnow@users.noreply.github.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Hi,
Clarified the querier's role in querying both ingesters and backend storage. Also, Improved grammar and rephrased.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]