Docs: add note forbidding allowance of user input of JS #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
mckn
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Maybe change it as suggested to also highlight that the plugin developer should not enter any kind of code that will be executed in the browser or at the server side. So we should not allow the user to enter golang code either. Or code that gets executed on potential third party services.
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
mckn
approved these changes
Jan 13, 2025
leventebalogh
approved these changes
Jan 13, 2025
academo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note to best practices doc telling plugin developers not to allow the plugin's users to input random JS.
Fixes: #1233